Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoDiff] fix SR-12493 #30817

Merged
merged 1 commit into from
Apr 6, 2020
Merged

[AutoDiff] fix SR-12493 #30817

merged 1 commit into from
Apr 6, 2020

Conversation

marcrasi
Copy link

@marcrasi marcrasi commented Apr 5, 2020

We simply needed to upstream TypeSubstCloner::visitDifferentiableFunctionExtractInst.

The code has a detailed comment explaining what it does.

Resolves SR-12493.

We simply needed to upstream `TypeSubstCloner::visitDifferentiableFunctionExtractInst`.

The code has a detailed comment explaining what it does.
@marcrasi marcrasi requested a review from dan-zheng April 5, 2020 23:32
@marcrasi
Copy link
Author

marcrasi commented Apr 5, 2020

@swift-ci please test

Copy link
Contributor

@dan-zheng dan-zheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@dan-zheng
Copy link
Contributor

Merging to unblock progress!

@dan-zheng dan-zheng merged commit 15f512b into swiftlang:master Apr 6, 2020
@zoecarver
Copy link
Contributor

Is it possible that this change caused a failure on some linux bots? I saw what (I think) is an unrelated error when testing my PR and tracked the error to this forum post and then here.

Error:

12:26:01 ******************** TEST 'Swift(linux-x86_64) :: AutoDiff/compiler_crashers_fixed/sr12493-differentiable-function-extract-subst-function-type.swift' FAILED ********************
12:26:01 Script:
12:26:01 --
12:26:01 : 'RUN: at line 1';   /home/buildnode/jenkins/workspace/swift-PR-Linux/branch-master/buildbot_linux/swift-linux-x86_64/bin/swiftc -target x86_64-unknown-linux-gnu -toolchain-stdlib-rpath  -module-cache-path '/home/buildnode/jenkins/workspace/swift-PR-Linux/branch-master/buildbot_linux/swift-linux-x86_64/swift-test-results/x86_64-unknown-linux-gnu/clang-module-cache' -swift-version 4  -Xfrontend -ignore-module-source-info  -O /home/buildnode/jenkins/workspace/swift-PR-Linux/branch-master/swift/test/AutoDiff/compiler_crashers_fixed/sr12493-differentiable-function-extract-subst-function-type.swift
12:26:01 --
12:26:01 Exit Code: 254
12:26:01 
12:26:01 Command Output (stderr):
12:26:01 --
12:26:01 
clang-10: error: unable to execute command: Bus error (core dumped)
12:26:01 clang-10: error: linker command failed due to signal (use -v to see invocation)
12:26:01 <unknown>:0: error: link command failed with exit code 254 (use -v to see invocation)
12:26:01 
12:26:01 --
12:26:01 
12:26:01 ********************

@marcrasi
Copy link
Author

marcrasi commented May 7, 2020

I've seen this test pass on Linux before, so either it's flaky or #31134 is uncovering something that causes it to fail.

I'll try to repro on my Linux machine with/without #31134 and then try to fix it.

@zoecarver
Copy link
Contributor

Thanks, much appreciated. Let me know if I can help.

I can see that it passed before it was committed. But, this commit is also the only one in the blame list so it's likely flaky (or needs a config that's present on only some bots).

@marcrasi
Copy link
Author

marcrasi commented May 7, 2020

My guess right now is that it was a flake caused by the worker being low on memory or disk, not by anything the test does.

Evidence for this hypothesis:

So I'd suggest running the tests again, if you don't mind. If this test does fail again, then we can disable it and spend more time investigating why it is flaky.

@zoecarver
Copy link
Contributor

That sounds good to me. Thanks for doing a full investigation.

The reason I thought that it might not be a one-time thing is both the incremental build (see forum post) and my PR had the error. But, it could easily be something else (given the logs from the forum post are unfortunately missing).

@tbkka
Copy link
Contributor

tbkka commented Jun 15, 2020

We're seeing this test fail erratically on some configurations. (Most recently, Ubuntu 20.04). Any thoughts?

@dan-zheng
Copy link
Contributor

I created #32394 to temporarily disable the flaky test. SR-13021 tracks re-enabling it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants